-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP COLLABORA #40
WIP COLLABORA #40
Conversation
|
OK, so apparently, this doesn't work on a LAN anyway. Too bad ;( |
@oparoz I have no clue here actually, it's based on @ezraholm50 s work so far. But to answer your questions:
Thanks for your comments! Please keep testing as we develop it further. |
You're copying the script to a folder but then call it as if it was in your path.
Apart from that issue, it runs well on a LAN and I expect quite a few people use it that way, at least before it's ready to be connected to the Internet, but if Collabora doesn't work without it, then nothing you can do. |
Aah yes ofc, blunt miss.
Yeah, Nextcloud is installed before it's released, so running it in LAN would work. |
Maybe we should move all the code to a separate folder just like we do with Let's Encrypt and adjust the Let's Encrypt part so that all the config files are set there directly when the SSL cert is created instead? Also TODO:
|
Yes i think it's a good idea, to move in a separated folder and leave the final user run it at the end of the installation. From nextcloud website: |
Indeed we should so it is less prone to fails, if the cert is setup add another -d with office.samedomain and just tell the user they have to set the same ip as the root domain for office.samedomain. This way we rule out any coming user fails. |
What I mean is to simply move all the files to a separate dir so that we don't mix the original Let's Encrypt scripts. But it would be even better if we could get the scripts from Let's Encrypt original folder then just make the necessary changes to the Collabora Let's Encrypt files. That way we don't have to make changes in two places if something is changed in Let's Encrypt original folder. Makes sense? |
Yes :) |
@ezraholm50 I would really need your help here. Thanks! |
Whatsup mate, I'll come online on irc |
Some thoughts:
|
Update the correct websocket setting for the proxy configuration on the collabora script.
Submitted websocket update for collabora script. |
Let's merge this and improve it even more after that. @Ark74 Do you think you could get this in a working state? Would be awesome! |
|
||
|
||
|
||
bash $SCRIPTS/activate-ssl.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended to run at setup? And is the activate-ssl.sh modified already?
After #40 I've polished the script a bit and added some code, view the # out commented lines for info.
After #40 I've polished the script a bit and added some code, view the # out commented lines for info.
After #40 I've polished the script a bit and added some code, view the # out commented lines for info.
I'm thinking that we use Let's Encrypt seperatly and skip the SSL setup in this script as that's already done in activate-ssl.sh. Maybe we can export the domian variable in the Let's Encrypt script (as we already do in test-new-config.sh) and run Let's Encrypt before we setup the docker image? I'm on mobile now so I can't test. |
Yes exactly what i thought, it seems we would only need to: sed -i 's|-d $domain|-d $domain -d $COLLABORA|g' activate-ssl.sh And already set the path to /etc/letsencrypt/live/cloud-main-domain/xxx.pem for the vhost cert files. Currently I have no working setup to test it (got everything behind nginx and I can't take it offline) Did you manage to fix collabora/nginx @enoch85 ? |
Yup, I fixed it behind nginx last week actually. 😀 I will try to make this better later tonight. |
Omg, can you enlighten me? I really want to set it up aswell! |
Just have to get home first. Make sure you'll be online on IRC later tonight. :) |
No problem! |
After #40 I've polished the script a bit and added some code, view the # out commented lines for info.
Don't use the root mirror
cc @Pe46dro @ezraholm50 Please review and make necessary changes. Thanks!